Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrap the SDK-internal MeterProvider with a shim to replace otelcol_ with otelsdk_ #760

Merged
merged 3 commits into from
Sep 6, 2024
Merged

Wrap the SDK-internal MeterProvider with a shim to replace otelcol_ with otelsdk_ #760

merged 3 commits into from
Sep 6, 2024

Conversation

jmacd
Copy link
Member

@jmacd jmacd commented Sep 6, 2024

Description: This will alleviate heavy confusion resulting from all internal Go trace/metrics SDKs reporting collector metrics that we use to monitor internal collectors.

@jmacd
Copy link
Member Author

jmacd commented Sep 6, 2024

Tested: manually

A local OTC w/ debug exporter shows metrics from the examples/metrics demo like:

Descriptor:
     -> Name: otelsdk_exporter_sent_wire
     -> Description: Number of bytes sent on the wire by the component.
     -> Unit: bytes
     -> DataType: Sum
     -> IsMonotonic: true
     -> AggregationTemporality: Delta
NumberDataPoints #0
Data point attributes:
     -> exporter: Str(otel_sdk_metric_otlp)
     -> method: Str(/opentelemetry.proto.collector.metrics.v1.MetricsService/Export)

@jmacd jmacd merged commit 8afd5cc into main Sep 6, 2024
1 check passed
@jmacd jmacd deleted the jmacd/wrapcol branch September 6, 2024 20:01
@jmacd jmacd mentioned this pull request Sep 6, 2024
Merged
jmacd added a commit that referenced this pull request Sep 9, 2024
@jmacd
Release version 1.31.0 (#761)
eb452ca 
- SDK-internal metrics: replace "otelcol_" prefix with "otelsdk_"
[#760](#760)
- Traces exporter: allow custom meter/trace providers
[#739](#739)
- Use correct default retry settings.
[#741](#741)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthagenbuch matthagenbuch matthagenbuch approved these changes

@gdvalle gdvalle Awaiting requested review from gdvalle

@moh-osman3 moh-osman3 Awaiting requested review from moh-osman3

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmacd @matthagenbuch